svn: /pear/pearweb/trunk/include/pepr/ pepr-ppvote.php

[Daniel O'Connor]

clockwerx Wed, 13 Apr 2011 10:18:19 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=310199

Log:
Prevent undefined variable notice, shift to QF2

Changed paths:
U pear/pearweb/trunk/include/pepr/pepr-ppvote.php

Modified: pear/pearweb/trunk/include/pepr/pepr-ppvote.php
===================================================================
--- pear/pearweb/trunk/include/pepr/pepr-ppvote.php 2011-04-13 09:30:18 UTC (rev 310198)
+++ pear/pearweb/trunk/include/pepr/pepr-ppvote.php 2011-04-13 10:18:19 UTC (rev 310199)
@@ -34,7 +34,7 @@
var $pkg_prop_id;
var $user_handle;
var $value;
- var $reviews;
+ var $reviews = array();
var $is_conditional;
var $comment;
var $timestamp;
@@ -91,8 +91,11 @@
function getReviews($humanReadable = false)
{
if ($humanReadable) {
- foreach ($this->reviews as $review) {
- $res[] = $GLOBALS['proposalReviewsMap'][$review];
+ $res = array();
+ if (!empty($this->reviews)) {
+ foreach ($this->reviews as $review) {
+ $res[] = $GLOBALS['proposalReviewsMap'][$review];
+ }
}
return $res;
}

[Daniel O'Connor]

clockwerx Wed, 13 Apr 2011 10:19:29 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=310200

Log:
Cast to array

Changed paths:
U pear/pearweb/trunk/include/pepr/pepr-ppvote.php

Modified: pear/pearweb/trunk/include/pepr/pepr-ppvote.php
===================================================================
--- pear/pearweb/trunk/include/pepr/pepr-ppvote.php 2011-04-13 10:18:19 UTC (rev 310199)
+++ pear/pearweb/trunk/include/pepr/pepr-ppvote.php 2011-04-13 10:19:29 UTC (rev 310200)
@@ -93,7 +93,7 @@
if ($humanReadable) {
$res = array();
if (!empty($this->reviews)) {
- foreach ($this->reviews as $review) {
+ foreach ((array)$this->reviews as $review) {
$res[] = $GLOBALS['proposalReviewsMap'][$review];
}
}